packaging: remove old installations

- removes startup links, reg keys, and uninstall links from
  antecedent versions of Jami

Change-Id: If5c4e6c95244560b62f1eec985583cf04b7edd5e

JamiInstaller/Product.wxs

@@ -17,6 +17,7 @@
             <ComponentRef Id="ApplicationShortcutDesktop" />
             <ComponentRef Id="ApplicationShortcutStartMenu" />
         </Feature>
+
       <!--Visual C++-->
       <DirectoryRef Id="TARGETDIR">
         <Merge Id="VCRedist" SourceFile="$(env.VCRedistMergeModule)" DiskId="1" Language="0" />
@@ -50,6 +51,11 @@
         <WixVariable Id="WixUIBannerBmp" Value="top-banner.bmp" />
         <WixVariable Id="WixUIDialogBmp" Value="main-banner.bmp" />
         <WixVariable Id="WixUISupportPerUser" Value="0" />
+
+      <CustomAction Id="removeOldJamiFiles" Directory="APPLICATIONFOLDER"
+                    ExeCommand="cmd /c &quot;del vc_redist.x64.exe; del uninstall.exe;&quot;"
+                    Execute="deferred" Return="ignore" HideTarget="no" Impersonate="no" />
+
     </Product>
 
     <Fragment Id="DirectoryStructure">
@@ -70,17 +76,19 @@
                 <Shortcut Id="ApplicationShortcutDesktop" Name="$(var.Name)" Description="Launch $(var.Name)"
                     Target="[#fileMain.exe]" WorkingDirectory="INSTALLFOLDER" />
                 <RemoveFolder Id="DesktopFolder" On="uninstall" />
-                <RegistryValue Root="HKCU" Key="Software/$(var.Name)" Name="desktop" Type="integer" Value="1" KeyPath="yes" />
+                <RegistryValue Root="HKCU" Key="Software\jami.net\$(var.Name)" Name="desktop" Type="integer" Value="1" KeyPath="yes" />
             </Component>
         </DirectoryRef>
 
         <DirectoryRef Id="ApplicationProgramsFolder">
-            <Component Id="ApplicationShortcutStartMenu" Guid="*" Win64="yes">
-                <Shortcut Id="ApplicationShortcutStartMenu" Name="$(var.Name)" Description="Launch $(var.Name)"
+          <Component Id="ApplicationShortcutStartMenu" Guid="*" Win64="yes">
+            <Shortcut Id="ApplicationShortcutStartMenu" Name="$(var.Name)" Description="Launch $(var.Name)"
                     Target="[#fileMain.exe]" WorkingDirectory="INSTALLFOLDER" />
-                <RemoveFolder Id="StartMenuFolder" On="uninstall" />
-                <RegistryValue Root="HKCU" Key="Software/$(var.Name)" Name="startmenu" Type="integer" Value="1" KeyPath="yes" />
-            </Component>
+            <RemoveFolder Id="StartMenuFolder" On="uninstall" />
+            <RegistryValue Root="HKCU" Key="Software\jami.net\$(var.Name)" Name="startmenu" Type="integer" Value="1" KeyPath="yes" />
+            <RemoveRegistryKey Id='removeBadShortcutRegKey' Root='HKLM' Key='Software/$(var.Name)' Action='removeOnInstall'/>
+            <RemoveRegistryKey Id='removeOldUninstRegKey' Root='HKLM' Key='SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\$(var.Manufacturer) $(var.Name)' Action='removeOnInstall'/>
+          </Component>
         </DirectoryRef>
     </Fragment>
 
@@ -108,6 +116,7 @@
           </InstallUISequence>
         </UI>
         <InstallExecuteSequence>
+          <Custom Action="removeOldJamiFiles" After="RemoveFiles" />
           <Custom Action="LaunchApplication_nonUI" After="InstallFinalize"> WIXNONUILAUNCH </Custom>
           <Custom Action="Overwrite_WixSetDefaultPerMachineFolder" After="WixSetDefaultPerMachineFolder" />
         </InstallExecuteSequence>

main.cpp

@@ -132,6 +132,8 @@ main(int argc, char* argv[])
         return 0;
     }
 
+    Utils::removeOldVersions();
+
     QApplication::setAttribute(Qt::AA_EnableHighDpiScaling, false);
     QGuiApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);
 

newwizardwidget.cpp

@@ -437,7 +437,7 @@ NewWizardWidget::processWizardInformations()
     changePage(ui->spinnerPage);
     createAccount();
 
-    Utils::CreateStartupLink();
+    Utils::CreateStartupLink(L"Jami");
 }
 
 void

utils.cpp

@@ -49,7 +49,7 @@
 #include "version.h"
 
 bool
-Utils::CreateStartupLink()
+Utils::CreateStartupLink(const std::wstring& wstrAppName)
 {
 #ifdef Q_OS_WIN
     TCHAR szPath[MAX_PATH];
@@ -61,7 +61,7 @@ Utils::CreateStartupLink()
     SHGetFolderPathW(NULL, CSIDL_STARTUP, NULL, 0, startupPath);
 
     std::wstring linkPath(startupPath);
-    linkPath += TEXT("\\Jami.lnk");
+    linkPath += std::wstring(TEXT("\\") + wstrAppName + TEXT(".lnk"));
 
     return Utils::CreateLink(programPath.c_str(), linkPath.c_str());
 #else
@@ -100,32 +100,81 @@ Utils::CreateLink(LPCWSTR lpszPathObj, LPCWSTR lpszPathLink) {
 }
 
 void
-Utils::DeleteStartupLink() {
+Utils::DeleteStartupLink(const std::wstring& wstrAppName) {
 #ifdef Q_OS_WIN
     TCHAR startupPath[MAX_PATH];
     SHGetFolderPathW(NULL, CSIDL_STARTUP, NULL, 0, startupPath);
 
     std::wstring linkPath(startupPath);
-    linkPath += TEXT("\\Jami.lnk");
+    linkPath += std::wstring(TEXT("\\") + wstrAppName + TEXT(".lnk"));
 
     DeleteFile(linkPath.c_str());
 #endif
 }
 
 bool
-Utils::CheckStartupLink() {
+Utils::CheckStartupLink(const std::wstring& wstrAppName) {
 #ifdef Q_OS_WIN
     TCHAR startupPath[MAX_PATH];
     SHGetFolderPathW(NULL, CSIDL_STARTUP, NULL, 0, startupPath);
 
     std::wstring linkPath(startupPath);
-    linkPath += TEXT("\\Jami.lnk");
+    linkPath += std::wstring(TEXT("\\") + wstrAppName + TEXT(".lnk"));
     return PathFileExists(linkPath.c_str());
 #else
     return true;
 #endif
 }
 
+const char*
+Utils::WinGetEnv(const char* name)
+{
+#ifdef Q_OS_WIN
+    const DWORD buffSize = 65535;
+    static char buffer[buffSize];
+    if (GetEnvironmentVariableA(name, buffer, buffSize)) {
+        return buffer;
+    } else {
+        return 0;
+    }
+#else
+    return 0;
+#endif
+}
+
+void
+Utils::removeOldVersions()
+{
+#ifdef Q_OS_WIN
+    // As per: https://git.jami.net/savoirfairelinux/ring-client-windows/issues/429
+    // NB: As only the 64-bit version of this application is distributed, we will only
+    // remove 1. the configuration reg keys for Ring-x64, 2. the startup links for Ring,
+    // 3. the winsparkle reg keys. The NSIS uninstall reg keys for Jami-x64 are removed
+    // by the MSI installer.
+    // Uninstallation of Ring, either 32 or 64 bit, is left to the user.
+    // The current version of Jami will attempt to kill Ring.exe upon start if a startup
+    // link is found.
+    QString node64 = "HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node";
+    QString hkcuSoftwareKey = "HKEY_CURRENT_USER\\Software\\";
+    QString uninstKey = "\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\";
+    QString company = "Savoir-Faire Linux";
+
+    // 1. configuration reg keys for Ring-x64
+    QSettings(hkcuSoftwareKey + "jami.net\\Ring", QSettings::NativeFormat).remove("");
+    QSettings(hkcuSoftwareKey + "ring.cx", QSettings::NativeFormat).remove("");
+    // 2. unset Ring as a startup application
+    if (Utils::CheckStartupLink(TEXT("Ring"))) {
+        qDebug() << "Found startup link for Ring. Removing it and killing Ring.exe.";
+        Utils::DeleteStartupLink(TEXT("Ring"));
+        QProcess::execute("taskkill /im Ring.exe /f");
+    }
+    // 3. remove registry entries for winsparkle(both Jami-x64 and Ring-x64)
+    QSettings(hkcuSoftwareKey + company, QSettings::NativeFormat).remove("");
+#else
+    return;
+#endif
+}
+
 QString
 Utils::GetRingtonePath() {
 #ifdef Q_OS_WIN
@@ -236,18 +285,6 @@ void Utils::showSystemNotification(QWidget* widget,
     QApplication::alert(widget, delay);
 }
 
-const char*
-Utils::WinGetEnv(const char* name)
-{
-    const DWORD buffSize = 65535;
-    static char buffer[buffSize];
-    if (GetEnvironmentVariableA(name, buffer, buffSize)) {
-        return buffer;
-    } else {
-        return 0;
-    }
-}
-
 void
 Utils::cleanUpdateFiles()
 {