1. 02 Jan, 2019 1 commit
  2. 29 Dec, 2018 2 commits
  3. 26 Dec, 2018 1 commit
  4. 17 Dec, 2018 1 commit
  5. 12 Dec, 2018 1 commit
  6. 07 Dec, 2018 1 commit
  7. 05 Dec, 2018 1 commit
  8. 29 Nov, 2018 2 commits
  9. 23 Nov, 2018 2 commits
  10. 04 Oct, 2018 1 commit
  11. 28 Sep, 2018 1 commit
  12. 14 Sep, 2018 1 commit
    • Hugo Lefeuvre's avatar
      fix memory leaks, hazardous frees and misc issues · 55d24730
      Hugo Lefeuvre authored
      accountgeneraltab:
      + remove useless <iostream> import
      
      accountmigrationview:
      + remove useless <iostream> import
      + add missing <memory> import
      
      currentcallview:
      + remove useless <iostream> import
      + add missing <memory> and <string> import
      + use g_debug instead of std::cout (not the standard debug output)
      
      ringmainwindow:
      + fix multiple memory leaks in print_account_and_state(),
        on_clear_all_history_foreach() and changeAccountSelection()
      + fix use of deprecated method gtk_entry_set_icon_from_stock()
      + use G_GNUC_UNUSED to remove unused parameter warnings
      + remove various unused variables
      + remove unused function on_save_accounts_timeout()
      + fix multiple places where char* was passed to printf-style function
        with %i formatter
      
      ringwelcomeview:
      + fix multiple memory leaks in ring_welcome_update_view() and
        render_account_avatar()
      + return FALSE in case of failure in draw_qrcode()
      
      webkitchatcontainer:
      + webkit_chat_container_execute_js should take const char*, not char*
      + return true in case of success in webview_chat_context_menu()
      
      usernameregistrationbox:
      + make "Enter the password of your Ring account" string translatable
      
      ring_client:
      + fix multiple memory leaks in ring_client_open()
      
      ring_notify:
      + improve ring_hide_notification() return values
      + fix multiple potential hazardous free() calls
      
      video_widget:
      + fix leak in case of error in video_widget_on_drag_data_received()
      + fix hazardous free() call in switch_video_input_file() (uri might be
        NULL even if the answer of the dialog is GTK_RESPONSE_ACCEPT)
      
      Change-Id: I7db8b63ba1b8ad272d464d0739b2fe24cc18c0b4
      Gitlab: #917
      Gitlab: #821Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      55d24730
  13. 12 Sep, 2018 2 commits
  14. 04 Sep, 2018 1 commit
  15. 27 Jul, 2018 1 commit
    • Sébastien Blin's avatar
      ringnotify: rewrite notification system · cc4e824b
      Sébastien Blin authored
      Ring will now use three types of notifications:
      
      1. Call notifications: opened when an incoming call is here
      and closed at the end of the call.
      2. Request notifications: opened when a new trust request
      arrives and closed when the user accepts/refuse/block or
      just open the conversation.
      3. Chat notifications: arrives with new interactions and if
      the current conversation is different or the client not focused. Closed
      by Gnome or when the conversation is opened.
      
      Change-Id: I5e5abf20507bac8bb37c429bc929c671fe66bd6b
      Gitlab: #868Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      cc4e824b
  16. 26 Jul, 2018 1 commit
  17. 24 Jul, 2018 1 commit
  18. 13 Jul, 2018 1 commit
  19. 12 Jul, 2018 2 commits
  20. 10 Jul, 2018 2 commits
  21. 06 Jul, 2018 4 commits
  22. 05 Jul, 2018 1 commit
    • Sébastien Blin's avatar
      newaccountsettings: add a new account settings page · 61c19d18
      Sébastien Blin authored
      Link the account settings page to the new models in LRC.
      
      ** Summary changes **
      
      + Link AvatarManipulation to new models and change the size of the
      widget
      + Redo the account combobox selector to show the avatar
      + Add the ability to see disabled accounts and linked conversations
      + Redo the whole accounts settings page and reorganize settings
      + Link the username registration widgets to new LRC
      + Add the ability to create SIP accounts from the wizard
      
      Change-Id: I43b15d1279ce1e3c8dee97b46fa6317aba272635
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      61c19d18
  23. 30 May, 2018 1 commit
    • Hugo Lefeuvre's avatar
      chatview: implement navbar · edad8832
      Hugo Lefeuvre authored
      Currently the navbar is implemented in native GTK, and has a pretty
      bad integration with the chatview. In this patch we implement a
      modern navbar *in* the chatview and remove the old GTK bar.
      
      *Changes summary*
      
      chatview, HTML/JS/CSS side:
      - Remove useless function setSendIcon from the chatview
      - Simplify setTemporary in the chatview
      - Use only one single showInvitation function instead of two
        showInvitation and hideInvitation functions.
      - Remove pointless/copy&pasted comments
      
      chatview, GTK side:
      - Simplify chatview update methods: instead of providing several
      separate functions to update the invitation/banned status of the chat
      view, only provide one (update_chatview_frame). This should have a
      good impact on the performances and simplify webkit crash handling.
      
      Change-Id: I6959240efd357fedb07d3c60d551efc8fca84812
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      edad8832
  24. 14 May, 2018 3 commits
    • Hugo Lefeuvre's avatar
      accountcreationwizard: close preview when hidden · 24356d47
      Hugo Lefeuvre authored
      Whenever the preview is created and run in the account creation
      wizard, there is no way to stop it. This is very annoying because
      it grabs the webcam rights without releasing them, and the camera
      led stays on, giving the user the impression to be observed.
      
      In this patch we add a mechanism similar to what is done in the
      general settings tab: we destroy and create the preview each time
      the preview is made visible / hidden. While not the most elegant
      solution it allows us to run the preview if and only if it is
      displayed & stop it otherwise.
      
      Also, we fix various issues in the account view:
       - when + icon is double clicked, the settings space becomes blank.
         Now if + is clicked while account wizard is open, the account
         wizard gets closed.
       - when an account is selected in the account selection tab while
         the wizard is displayed, nothing "seems to happen". Instead,
         quit the wizard and open the selected tab.
       - when account view is openened for the first time, the settings
         space is blank. Instead, default select an account.
      
      Change-Id: I1e12333e654f70d590886e2aa4f5112154f3068a
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      24356d47
    • Hugo Lefeuvre's avatar
      ringmainwindow: fix view inconsistency bug · b8a8057e
      Hugo Lefeuvre authored
      We should switch to the ring main window before updating the lrc.
      Otherwise the conversation is going to be selected by
      slotFilterChanged (signal triggered by updateLrc) while the view will
      be later changed to welcome view without updating the conversationview
      selection.
      
      Change-Id: I2caea45dc2a11d90b409cdb06e9ba9eaa14d9f21
      Tuleap: #1876
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      b8a8057e
    • Sébastien Blin's avatar
      settings: link settings tabs to selected account · 276202f9
      Sébastien Blin authored
      This patch does nothing for now, but prepare the migration to new
      LRC models.
      
      Change-Id: I55f63ad494e5d3516d4d01f72051997a430ef5df
      Reviewed-by: default avatarHugo Lefeuvre <hugo.lefeuvre@savoirfairelinux.com>
      276202f9
  25. 09 May, 2018 1 commit
    • Hugo Lefeuvre's avatar
      popupmenu: fix menu for banned accounts · ef608eae
      Hugo Lefeuvre authored
      Currently the popup menu stays the same even if the account is banned
      which may be very confusing for the user (place call or block contact
      options are everything but meaningful in this case !).
      
      In this patch we implement a specific menu for banned accounts.
      
      In addition to that, we also force a chat view refresh when
      the filter is updated.
      
      This patch requires LRC side changes in order to work properly.
      
      Change-Id: Iea545fe5cf54520e7aba92c7a87a736bc6d71d27
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      ef608eae
  26. 01 May, 2018 2 commits
    • Hugo Lefeuvre's avatar
      Refactoring of the accountContainer logic · 6f2ceb12
      Hugo Lefeuvre authored
      Before:
      
       - RingMainWindow has an unique_ptr to an AccountContainer
         accountContainer_.
      
       - each view / secondary class has its own *copy* of the account
         container pointer (given by ringmainwindow using
         accountContainer_.get()).
      
       - each time the reference to the struct Info is updated,
         accountContainer_ has to be reset()-ed and and the account
         container re-created by the RingMainWindow. This makes *all*
         copies of the account container pointer invalid (hence all
         view / secondary classes trying to access the account container
         before getting updated perform use-after-free / NULL pointer
         dereference).
      
       - These copies have to be manually updated ! (well, currently they
         are not updated at all)
      
      After:
      
       - RingMainWindow has a pointer to a struct Info from LRC.
      
       - Each view / secondary class has a pointer pointing to
         the struct Info pointer of RingMainWindow
      
       - Each time the reference to the struct Info is updated, the
         RingMainWindow updates its pointer. Since secondary classes and
         views hold a pointer to this pointer, they are automatically
         updated and there is no dangling pointer anymore.
      
      This requires no lrc side changes.
      
      Change-Id: I1329721920a3d42ad623f9fd7202b43700713eed
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      Reviewed-by: Guillaume Roguez's avatarGuillaume Roguez <guillaume.roguez@savoirfairelinux.com>
      6f2ceb12
    • Sébastien Blin's avatar
      datatransfer: automatically accepts images instead of awaiting · 03f071db
      Sébastien Blin authored
      Change-Id: I64f6a0e3b7d982d5e9848f15ea6276a972ab8d44
      Reviewed-by: Philippe Gorley's avatarPhilippe Gorley <philippe.gorley@savoirfairelinux.com>
      03f071db
  27. 24 Apr, 2018 1 commit
  28. 19 Apr, 2018 1 commit