1. 02 Jan, 2019 1 commit
  2. 26 Dec, 2018 1 commit
  3. 12 Dec, 2018 1 commit
  4. 08 Dec, 2018 1 commit
  5. 07 Dec, 2018 2 commits
    • Hugo Lefeuvre's avatar
      currentcallview: fix broken peer info panel · 4f3b5d1d
      Hugo Lefeuvre authored
      + make sure updateNameAndPhoto() is called at least once in setCallInfo().
        (calling it in in the state changed callback is not sufficient since it
        might never be executed)
      + move various gtk_widget_set_sensitive() calls from updateDetails() to
        updateState(), there is no reason to execute those every second
      + always display bestId (registered name of ring info hash), display alias
        if available
      + do not display quality button and video on/off button in audio only calls
      
      Change-Id: I4127f4a88595ba09bef7696814f0dac7ea38329f
      4f3b5d1d
    • Sébastien Blin's avatar
      medias: link to new media API · 047a66d6
      Sébastien Blin authored
      Change-Id: I7b8e5a2d08ecbdcb9baba84e6df811c1012299db
      Reviewed-by: Philippe Gorley's avatarPhilippe Gorley <philippe.gorley@savoirfairelinux.com>
      047a66d6
  6. 05 Dec, 2018 1 commit
  7. 14 Sep, 2018 1 commit
    • Hugo Lefeuvre's avatar
      fix memory leaks, hazardous frees and misc issues · 55d24730
      Hugo Lefeuvre authored
      accountgeneraltab:
      + remove useless <iostream> import
      
      accountmigrationview:
      + remove useless <iostream> import
      + add missing <memory> import
      
      currentcallview:
      + remove useless <iostream> import
      + add missing <memory> and <string> import
      + use g_debug instead of std::cout (not the standard debug output)
      
      ringmainwindow:
      + fix multiple memory leaks in print_account_and_state(),
        on_clear_all_history_foreach() and changeAccountSelection()
      + fix use of deprecated method gtk_entry_set_icon_from_stock()
      + use G_GNUC_UNUSED to remove unused parameter warnings
      + remove various unused variables
      + remove unused function on_save_accounts_timeout()
      + fix multiple places where char* was passed to printf-style function
        with %i formatter
      
      ringwelcomeview:
      + fix multiple memory leaks in ring_welcome_update_view() and
        render_account_avatar()
      + return FALSE in case of failure in draw_qrcode()
      
      webkitchatcontainer:
      + webkit_chat_container_execute_js should take const char*, not char*
      + return true in case of success in webview_chat_context_menu()
      
      usernameregistrationbox:
      + make "Enter the password of your Ring account" string translatable
      
      ring_client:
      + fix multiple memory leaks in ring_client_open()
      
      ring_notify:
      + improve ring_hide_notification() return values
      + fix multiple potential hazardous free() calls
      
      video_widget:
      + fix leak in case of error in video_widget_on_drag_data_received()
      + fix hazardous free() call in switch_video_input_file() (uri might be
        NULL even if the answer of the dialog is GTK_RESPONSE_ACCEPT)
      
      Change-Id: I7db8b63ba1b8ad272d464d0739b2fe24cc18c0b4
      Gitlab: #917
      Gitlab: #821Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      55d24730
  8. 13 Sep, 2018 1 commit
  9. 16 Aug, 2018 1 commit
  10. 03 Aug, 2018 1 commit
  11. 24 Jul, 2018 1 commit
  12. 12 Jul, 2018 1 commit
  13. 04 Jul, 2018 1 commit
  14. 08 Jun, 2018 1 commit
  15. 05 Jun, 2018 1 commit
  16. 30 May, 2018 1 commit
    • Hugo Lefeuvre's avatar
      chatview: implement navbar · edad8832
      Hugo Lefeuvre authored
      Currently the navbar is implemented in native GTK, and has a pretty
      bad integration with the chatview. In this patch we implement a
      modern navbar *in* the chatview and remove the old GTK bar.
      
      *Changes summary*
      
      chatview, HTML/JS/CSS side:
      - Remove useless function setSendIcon from the chatview
      - Simplify setTemporary in the chatview
      - Use only one single showInvitation function instead of two
        showInvitation and hideInvitation functions.
      - Remove pointless/copy&pasted comments
      
      chatview, GTK side:
      - Simplify chatview update methods: instead of providing several
      separate functions to update the invitation/banned status of the chat
      view, only provide one (update_chatview_frame). This should have a
      good impact on the performances and simplify webkit crash handling.
      
      Change-Id: I6959240efd357fedb07d3c60d551efc8fca84812
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      edad8832
  17. 01 May, 2018 1 commit
    • Hugo Lefeuvre's avatar
      Refactoring of the accountContainer logic · 6f2ceb12
      Hugo Lefeuvre authored
      Before:
      
       - RingMainWindow has an unique_ptr to an AccountContainer
         accountContainer_.
      
       - each view / secondary class has its own *copy* of the account
         container pointer (given by ringmainwindow using
         accountContainer_.get()).
      
       - each time the reference to the struct Info is updated,
         accountContainer_ has to be reset()-ed and and the account
         container re-created by the RingMainWindow. This makes *all*
         copies of the account container pointer invalid (hence all
         view / secondary classes trying to access the account container
         before getting updated perform use-after-free / NULL pointer
         dereference).
      
       - These copies have to be manually updated ! (well, currently they
         are not updated at all)
      
      After:
      
       - RingMainWindow has a pointer to a struct Info from LRC.
      
       - Each view / secondary class has a pointer pointing to
         the struct Info pointer of RingMainWindow
      
       - Each time the reference to the struct Info is updated, the
         RingMainWindow updates its pointer. Since secondary classes and
         views hold a pointer to this pointer, they are automatically
         updated and there is no dangling pointer anymore.
      
      This requires no lrc side changes.
      
      Change-Id: I1329721920a3d42ad623f9fd7202b43700713eed
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      Reviewed-by: Guillaume Roguez's avatarGuillaume Roguez <guillaume.roguez@savoirfairelinux.com>
      6f2ceb12
  18. 31 Jan, 2018 1 commit
  19. 25 Jan, 2018 2 commits
  20. 14 Dec, 2017 1 commit
  21. 04 Dec, 2017 1 commit
  22. 01 Dec, 2017 1 commit
  23. 27 Nov, 2017 2 commits
  24. 10 Nov, 2017 1 commit
  25. 06 Nov, 2017 1 commit
  26. 02 Nov, 2017 1 commit
  27. 26 Jul, 2017 1 commit
  28. 25 Jul, 2017 1 commit
  29. 19 Jul, 2017 1 commit
  30. 17 Jul, 2017 1 commit
  31. 05 Jul, 2017 1 commit
  32. 23 May, 2017 1 commit
    • Guillaume Roguez's avatar
      set auto-quality off by default · 567a97b3
      Guillaume Roguez authored
      Commit [8809293c: Prevent warnings about size allocation] has the
      side effect to enable the auto-quality by default.
      It's the opposite property we want, daemon disable by default.
      Also move the line of property setting to be in same logical block.
      
      Change-Id: Id5a17e159294a55eaa749761a101cf3488fb1f3d
      567a97b3
  33. 19 May, 2017 2 commits
  34. 17 May, 2017 1 commit
    • Stepan Salenikovich's avatar
      Prevent warnings about size allocation · 8809293c
      Stepan Salenikovich authored
      The overlay controls of the CurrentCallView were being placed in
      the VideoWidget before the view that it is in was being allocated
      its full size. This resulted in several warnings being printed
      about size allocation each time a CurrentCallView is displayed.
      
      We prevent this by not inserting the controls until we get a
      size-allocate signal.
      
      Change-Id: I1c1a42a873182a125722879ee09c037120c9611d
      Tuleap: #1525
      Reviewed-by: default avatarNicolas Jäger <nicolas.jager@savoirfairelinux.com>
      8809293c
  35. 16 May, 2017 1 commit
  36. 17 Apr, 2017 1 commit